This repository was archived by the owner on Jun 18, 2024. It is now read-only.
[901] Add PhD and MPhil school fields on the student pages #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tm-kn
force-pushed
the
901-student-research-profiles-fix
branch
from
c8156da to
94bbe5e
Compare
m1kola
approved these changes
Jul 27, 2017
django-verdant/rca/models.py
Outdated
| SCHOOL_PROGRAMME_ERROR = 'Please only select a School if your degree ' \ | ||
| 'is not associated with a specific programme.' | ||
|
|
||
| errors = {k: [] for k in ('phd_school', 'mphil_school')} |
Contributor
There was a problem hiding this comment.
Why not just errors['phd_school'] = [SCHOOL_PROGRAMME_ERROR] and errors['mphil_school'] = [SCHOOL_PROGRAMME_ERROR]? :)
Member
Author
|
Before merging... Needs some work so migrations are run in order - #115 (comment). |
tm-kn
force-pushed
the
901-student-research-profiles-fix
branch
from
13f2e72 to
c07acbb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://projects.torchbox.com/projects/rca-django-cms-project/tickets/901
Please be advised that this pull request comments out two migrations that were used for migrating 6 schools to 4 , but are no longer required and were causing issues when runningFixed by changing the faulty migration's dependencies.manage.py test.