This repository was archived by the owner on Jun 18, 2024. It is now read-only.
WIP: Added LinkedIn share link to share button. Also update Twitter share … #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…link to use https
tm-kn
suggested changes
Aug 24, 2018
| <li><a href="https://www.facebook.com/sharer/sharer.php?u={{ self.url }}">On Facebook</a></li> | ||
| <li><a href="http://twitter.com/share?text={{ self.title }}&url={{ self.url }}&via={{ global_default_twitter_handle }}">On Twitter</a></li> | ||
| <li><a href="https://twitter.com/share?text={{ self.title }}&url={{ self.url }}&via={{ global_default_twitter_handle }}">On Twitter</a></li> | ||
| <li><a href="https://www.linkedin.com/shareArticle?mini=true&url={{ self.url }}">On LinkedIn</a></li> |
Member
There was a problem hiding this comment.
I am actually wondering if we should not use |urlencode on URLs. Even if the other ones don't have it. Can you please check this? Thanks.
Contributor
Author
There was a problem hiding this comment.
I've added the urlencode and tested the links now.
tm-kn
suggested changes
Aug 24, 2018
| <li class="last"><a href="mailto:?subject=Royal College of Art: {{ self.title }}&body=I thought you might be interested in this page on the Royal College of Art site: {{ self.url }}.">By Email</a></li> | ||
| <li><a href="https://www.facebook.com/sharer/sharer.php?u={{ self.url|urlencode }}">On Facebook</a></li> | ||
| <li><a href="https://twitter.com/share?text={{ self.title|urlencode }}&url={{ self.url|urlencode }}&via={{ global_default_twitter_handle|urlencode }}">On Twitter</a></li> | ||
| <li><a href="https://www.linkedin.com/shareArticle?mini=true&url={{ self.url|urlencode }}">On LinkedIn</a></li> |
Member
There was a problem hiding this comment.
&? Except for that it looks good to me. Thanks!
Contributor
Author
There was a problem hiding this comment.
Sorry, I was confused as the original link on that page had &body= instead of just &body=. I have updated it to just & now. Hopefully this is the last change!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review only. Please do not merge yet!
Add LinkedIn share link to share button. Ticket: https://projects.torchbox.com/projects/rca-django-cms-project/tickets/942