Skip to content

Chunk file streaming for improved performance #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alxbridge merged 2 commits into from
Nov 12, 2025
Merged

Chunk file streaming for improved performance #44

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7df6bb7
Add chunking to file streaming for improved performance
alxbridge Nov 12, 2025
7e1b19c
Add test for handling of successful-but-empty responses
alxbridge Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,15 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

- Improve performance of streamed file downloads changed in v0.8 ([#44](https://github.com/torchbox/wagtail-bynder/pull/44/) @alxbridge

## [0.8] - 2025-11-12

### Fixed

- Improved handling for unexpected server error responses when downloading Bynder assets ([#43](hhttps://github.com/torchbox/wagtail-bynder/pull/43/)) @alxbridge
- Improved handling for unexpected server error responses when downloading Bynder assets ([#43](https://github.com/torchbox/wagtail-bynder/pull/43/)) @alxbridge

## [0.7] - 2025-01-15

Expand Down
10 changes: 7 additions & 3 deletions src/wagtail_bynder/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ def download_file(
file = BytesIO()
# Stream the file to memory. We use iter_content() instead of the default iterator for requests.Response,
# as the latter uses iter_lines() which isn't suitable for streaming binary data.
for chunk in response.iter_content():
if not chunk:
continue
# Get data in largish 8KB chunks, for more performant streaming while staying within CPU cache limits
for chunk in response.iter_content(chunk_size=8192):
file.write(chunk)
if file.tell() > max_filesize:
file.truncate(0)
Expand All @@ -47,6 +46,11 @@ def download_file(
)

size = file.tell()
# Catch empty case where iter_content wouldn't have iterated
if size == 0:
Comment thread
zerolab marked this conversation as resolved.
raise BynderAssetDownloadError(
f"Downloaded file '{name}' from Bynder is empty."
)
file.seek(0)

content_type, charset = mimetypes.guess_type(name)
Expand Down