Wagtail 7.3 and 7.4 LTS maintenance - #77
Merged
Merged
Conversation
Drop Python 3.9, Django 5.0, and Wagtail < 7.0 from the declared support window (all out of upstream support). Add Python 3.14, Django 5.2 LTS, Django 6.0, and Wagtail 7.0 LTS / 7.3 / 7.4 LTS, with the tox matrix respecting each Django release's official Python compatibility table. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Refresh the development tooling to current upstream versions, keeping the ruff workflow pinned to the same version as the pre-commit hook. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nickmoreton
marked this pull request as draft
May 12, 2026 13:36
Ruff 0.15 removed the implicit 'check' subcommand alias, so invoking 'ruff <path>' now exits with an error. Switch the workflow to the explicit 'ruff check' invocation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Wagtail 7.3 changed the initial-state behaviour around the wagtailcore.Page locale field, so loading the existing fixture now fails with a NOT NULL constraint violation on locale_id. Add the default 'en' Locale via natural key to both fixture pages so loaddata succeeds across all supported Wagtail versions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The earlier natural-key form (["en"]) failed deserialization because loaddata does not enable natural foreign keys here, so the value was treated as a literal pk. The initial Locale created by wagtailcore.0054_initial_locale has pk=1, so reference it directly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nickmoreton
marked this pull request as ready for review
May 12, 2026 13:56
zerolab
reviewed
May 13, 2026
Comment on lines
+10
to
+17
| - Drop support for Python < 3.10 | ||
| - Drop support for Wagtail < 6.3 | ||
| - Drop testing for Python 3.8 | ||
| - Drop support for Python 3.9 (EOL 2025-10-31) | ||
| - Drop support for Wagtail < 7.0 and Django 5.0 (both out of upstream support) | ||
| - Add support for Python 3.14 | ||
| - Add support for Django 5.2 LTS and Django 6.0 | ||
| - Add support for Wagtail 7.0 LTS, 7.3, and 7.4 LTS |
Member
There was a problem hiding this comment.
Let's merge these down to 2 lines - "Added ...", "Removed ..."
zerolab
reviewed
May 13, 2026
zerolab
reviewed
May 13, 2026
Co-authored-by: Dan Braghiș <31622+zerolab@users.noreply.github.com>
Co-authored-by: Dan Braghiș <31622+zerolab@users.noreply.github.com>
Contributor
Author
|
@zerolab Can this be merged now? |
zerolab
reviewed
May 26, 2026
Comment on lines
+10
to
+22
| ## Added | ||
|
|
||
| - Add support for Python 3.14 | ||
| - Add support for Django 5.2 LTS and Django 6.0 | ||
| - Add support for Wagtail 7.0 LTS, 7.3, and 7.4 LTS | ||
|
|
||
| ## Removed | ||
|
|
||
| - Drop support for Python < 3.10 | ||
| - Drop support for Wagtail < 6.3 | ||
| - Drop testing for Python 3.8 | ||
| - Drop support for Python 3.9 (EOL 2025-10-31) | ||
| - Drop support for Wagtail < 7.0 and Django 5.0 (both out of upstream support) |
Member
There was a problem hiding this comment.
Needs to be compacted.
@nickmoreton please keep these concise in the future, in all maintenance PRs.
zerolab
reviewed
May 26, 2026
zerolab
requested changes
May 26, 2026
Co-authored-by: Dan Braghiș <31622+zerolab@users.noreply.github.com>
zerolab
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-commit-hooksv4.6.0 → v6.0.0 andruffv0.4.4 → v0.15.12 (kept in sync between.pre-commit-config.yamland.github/workflows/ruff.yml).ruff check— Ruff 0.15 removed the implicitchecksubcommand alias.tests/testapp/fixtures/test.jsonso Page rows carry a usablelocale_id. Without it, fixture loading fails on Wagtail 7.3 / 7.4 withNOT NULL constraint failed: wagtailcore_page.locale_id. Uses an integer pk forPage.localeto match the fixture format.coverage-report,wagtailmain, andinteractivetox envs, plus the publish workflow, to Python 3.14.No package source changes were required — the package has no version-guard shims, and
Page.from_json/to_jsonremain available on Wagtail 7.4.Sources retrieved 2026-05-12:
Test plan
ruff checktox -e python3.14-django6.0-wagtail7.4passestox -e python3.10-django4.2-wagtail7.0passestox -e coverage-reportaggregates coverage on Python 3.14pre-commit run --all-filespasses with the new ruff and pre-commit-hooks versionsinteractiveenv against Wagtail 7.4 to confirm admin preview still renders🤖 Generated with Claude Code