Accumulated changes for v6.5.3 #3555
Merged
+167
−345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompt customizations (notably the PYTHONSTARTUP file used by vscode's terminal integration) can interfere with tests that run interactive interpreters in a subprocess. Run those interpreters in isolated mode to avoid this problem.)
Previouisly, when many header lines with the same name were found in an HTTP request or response, repeated string concatenation would result in quadratic performance. This change does the concatenation lazily (with a cache) so that repeated headers can be processed efficiently. Security: The previous behavior allowed a denial of service attack via a maliciously crafted HTTP message, but only if the max_header_size was increased from its default of 64kB.
This note referred to Tornado 6.3, which has been released.
This program does not demonstrate anything particularly interesting about Tornado, nor is it a good stylistic example to follow. Its handling of path validation is rudimentary and can be insecure in some configurations. It makes more sense to remove it than to try and improve it.
Several demos had handlers that redirected to a "next" URL provided as a query parameter without validating it first.
Prior to this change, _parseparam had O(n^2) behavior when parsing certain inputs, which could be a DoS vector. This change adapts logic from the equivalent function in the python standard library in https://github.com/python/cpython/pull/136072/files
We allow applications to set custom reason phrases for the HTTP status line (to support custom status codes), but if this were exposed to untrusted data it could be exploited in various ways. This commit guards against invalid reason phrases in both HTTP headers and in error pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.