Fix .distignore: exclude dev files, stop hiding README.md - #10
Merged
Conversation
.husky, .vscode, .wordpress-org, src, and tsconfig.json were being shipped in the release zip and SVN trunk/tags because .distignore never listed them. Also fix the phpcs.xml.dist entry (it was incorrectly written as .phpcs.xml.dist, so it wasn't excluded either), drop a pile of dead entries for files this repo doesn't have, and stop excluding README.md. Excluding README.md was also the root cause of the last release failing outright: wp.org's SVN pre-commit hook rejects a tag/trunk commit that has no readme file at all, and since readme.txt generation was dropped, README.md being excluded meant no readme shipped at all. README.md already follows the WordPress readme header format (Contributors, Stable tag, etc.), so shipping it as-is satisfies the hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.husky,.vscode,.wordpress-org,src/, andtsconfig.jsonbecause.distignorenever listed them, andphpcs.xml.distwasn't excluded either (the entry was misspelled as.phpcs.xml.dist). Dropped a bunch of other dead entries for files this repo doesn't have..distignoreexcludedREADME.md, and sincereadme.txtgeneration was removed earlier, no readme file at all was being shipped to wp.org. wp.org's SVN pre-commit hook rejects any tag/trunk commit with no readme file present, so the2.0.0tag commit was blocked. Fix: stop excludingREADME.md— it already follows the WordPress readme header format (Contributors, Stable tag, etc.), so shipping it asREADME.md(notreadme.txt) satisfies the hook.Test plan
composer lintpassesrsync -a --exclude-from=.distignore ./ /tmp/dist-check/that the resulting tree only containsREADME.md,build/,includes/,schedule-terms.php,vendor/— no.husky,.vscode,.wordpress-org,src/,tsconfig.json,tests/,bin/,node_modules/