Ticket33072 043 02 #1804
Open
Ticket33072 043 02 #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #33072 Signed-off-by: David Goulet <[email protected]>
This also adds the support for the option meaning, if set, every uncompressed directory requests will be served by the dirauth with a 503 error code. Signed-off-by: David Goulet <[email protected]>
Signed-off-by: David Goulet <[email protected]>
Pull Request Test Coverage Report for Build 8673
💛 - Coveralls |
teor2345
reviewed
Mar 18, 2020
doc/tor.1.txt
Outdated
|
|
||
| HIDDEN SERVICE OPTIONS | ||
| ---------------------- | ||
| == HIDDEN SERVICE OPTIONS |
There was a problem hiding this comment.
This change doesn't seem to belong in this pull request?
teor2345
reviewed
Mar 18, 2020
changes/ticket33072
Outdated
| @@ -0,0 +1,3 @@ | |||
| o Minor bugfix (directory authority): | |||
| - Always allow compressed directory requests. Fixes bug 33072; bugfix on | |||
There was a problem hiding this comment.
Should the changes file mention the new AuthDirRejectUncompressedRequests option?
teor2345
reviewed
Mar 18, 2020
src/core/mainloop/connection.c
Outdated
| return true; | ||
| } | ||
| if (c_method != NO_METHOD) { | ||
| /* Always answer compressed request. */ |
There was a problem hiding this comment.
Are we sure we always want to allow compressed requests?
We could just fall through to the other code, which might reject some requests, if the write bucket is low.
If an authority is getting a lot of compressed requests, we should prioritise voting over answering compressed requests.
teor2345
suggested changes
Mar 18, 2020
teor2345
suggested changes
Apr 9, 2020
Comment on lines
+3280
to
+3284
| * If we are a directory authority, false is returned (indicating that we | ||
| * should answer the request) if one of these conditions is met: | ||
| * - Connection is from a known relay (address is looked up). | ||
| * - AuthDirRejectRequestsUnderLoad is set to 0. | ||
| * - Compression is being used for the request (looking at c_method). |
There was a problem hiding this comment.
This comment doesn't match what the code does.
teor2345
reviewed
Apr 9, 2020
| @@ -0,0 +1,4 @@ | |||
| o Minor bugfix (directory authority): | |||
| - Always allow compressed directory requests and introduce option | |||
There was a problem hiding this comment.
Oh, the changes file is out of sync as well.
We let AuthDirRejectRequestsUnderLoad and the bandwidth buckets decide about compressed requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.