Skip to content

Conversation

@henadzit
Copy link
Contributor

@henadzit henadzit commented Nov 10, 2024

Description

Adds aliases to GROUP BY statements which helps to avoid ambiguous name errors.

Motivation and Context

This should fix #1386 and fix #1175.

How Has This Been Tested?

  • Added tests

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11766871659

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.162%

Totals Coverage Status
Change from base Build 11764062074: 0.0%
Covered Lines: 6084
Relevant Lines: 6709

💛 - Coveralls

@abondar abondar merged commit 905daaa into tortoise:develop Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If "id" is on values list, group by does not add the table name pgsql group by error

3 participants