Force task switch every 2000 rows when creating objects #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses event loop blocking by forcing a task switch every 2000 rows while processing large result sets.
- Introduces a CHUNK_SIZE constant to define the row interval for yielding.
- Modifies the loop over raw results to use enumerate and conditionally await asyncio.sleep(0) for a task switch.
CodSpeed Performance ReportMerging #1939 will not alter performanceComparing Summary
|
Pull Request Test Coverage Report for Build 14718896345Details
💛 - Coveralls |
abondar
previously approved these changes
Apr 25, 2025
henadzit
force-pushed
the
force-task-switch-when-loading
branch
from
bac6883 to
11626dc
Compare
henadzit
commented
Apr 28, 2025
| @@ -24,10 +30,6 @@ Added | |||
| ^^^^^ | |||
| - `.only` supports selecting related fields, e.g. `.only("related__field")` (#1923) | |||
|
|
|||
| Fixed | |||
There was a problem hiding this comment.
Removed a duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When selecting a large number of records, the process of converting database records to Tortoise objects might completely block the event loop. This PR introduces a task switch every 2000 rows to allow other workloads.
Motivation and Context
Fixes #1378.
I remember seeing other similar issues.
How Has This Been Tested?
make ciand testing it in my hobby project.Checklist: