Skip to content

Conversation

@waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Jun 6, 2025

Description

  1. ruff is faster that isort+black when make style, and we should reduce dev deps.
  2. remove coveralls from dev deps as it is only used by ci and it's installed by
    pip3 install --upgrade coveralls
  3. replace assert ... by raise ConfigurationError in tortoise/__init__.py to fix bandit complaint
  4. reformatted code by make style
  5. move some deps from dev to new groups, and then lock and upgrade deps

Motivation and Context

Clean dependencies

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 6, 2025

CodSpeed Performance Report

Merging #1963 will not alter performance

Comparing waketzheng:use-ruff (bf97d5e) with develop (cb72b8a)

Summary

✅ 16 untouched benchmarks

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15486407827

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 89.63%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/init.py 3 4 75.0%
Totals Coverage Status
Change from base Build 15464959908: -0.02%
Covered Lines: 6671
Relevant Lines: 7261

💛 - Coveralls

@waketzheng waketzheng requested review from abondar and henadzit June 6, 2025 10:20
Copy link
Contributor

@henadzit henadzit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@waketzheng waketzheng merged commit 4b4e4a5 into tortoise:develop Jun 6, 2025
9 checks passed
@waketzheng waketzheng deleted the use-ruff branch June 13, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants