Skip to content

docs: update documentation url #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 3, 2025
Merged

docs: update documentation url #1982

merged 4 commits into from
Aug 3, 2025

Conversation

@waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Jul 28, 2025 •
edited
Loading

Description

  1. change documentation url in pyproject.toml
  2. remove outdate item nose2 in docs/CONTRIBUTING.rst
  3. remove duplicated --cov-append in Makefile
image image

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1982 will not alter performance

Comparing waketzheng:fix-contributing (2f1c59f) with develop (65bc23e)

Summary

✅ 16 untouched benchmarks

@coveralls
Copy link

coveralls commented Jul 28, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16674932244

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.63%
Totals Coverage Status
Change from base Build 16380928706: 0.0%
Covered Lines: 6671
Relevant Lines: 7261
💛 - Coveralls

henadzit
henadzit reviewed Jul 28, 2025
View reviewed changes
Makefile
_typehints:
mypy $(checkfiles)
bandit -c pyproject.toml -r $(checkfiles)
twine check dist/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

twine and bandit aren't type hint checks. Otherwise, the PR looks good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed typehints to codeqc, is't ok?

@waketzheng waketzheng merged commit 8a13189 into tortoise:develop Aug 3, 2025
9 checks passed
@waketzheng waketzheng deleted the fix-contributing branch August 3, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henadzit henadzit henadzit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@waketzheng @coveralls @henadzit