Skip to content

[WIP] Fix pydantic optional#1985

Closed
waketzheng wants to merge 3 commits into
tortoise:developfrom
waketzheng:fix-pydantic-optional
Closed

[WIP] Fix pydantic optional#1985
waketzheng wants to merge 3 commits into
tortoise:developfrom
waketzheng:fix-pydantic-optional

Conversation

@waketzheng

Copy link
Copy Markdown
Contributor

Description

Fixes #1977

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq

codspeed-hq Bot commented Aug 1, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1985 will not alter performance

Comparing waketzheng:fix-pydantic-optional (415d8bd) with develop (65bc23e)

Summary

✅ 16 untouched benchmarks

@waketzheng waketzheng closed this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: pydantic_model_creator incorrectly marks fields as Optional when default is not None

1 participant