Skip to content

refactor: delete duplicate model name validate in OneToOneFieldInstance#2015

Merged
waketzheng merged 3 commits into
tortoise:developfrom
waketzheng:delete-duplicate-validate-model-name
Nov 24, 2025
Merged

refactor: delete duplicate model name validate in OneToOneFieldInstance#2015
waketzheng merged 3 commits into
tortoise:developfrom
waketzheng:delete-duplicate-validate-model-name

Conversation

@waketzheng

@waketzheng waketzheng commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

Description

self.validate_model_name(model_name) run twice when initial OneToOneFieldInstance

Motivation and Context

image image

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq

codspeed-hq Bot commented Nov 12, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #2015 will not alter performance

Comparing waketzheng:delete-duplicate-validate-model-name (1d059ff) with develop (5cac58d)

Summary

✅ 16 untouched

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19612987279

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 90.707%

Totals Coverage Status
Change from base Build 19610920362: -0.001%
Covered Lines: 6625
Relevant Lines: 7189

💛 - Coveralls

@waketzheng
waketzheng merged commit c45dd9d into tortoise:develop Nov 24, 2025
9 checks passed
@waketzheng
waketzheng deleted the delete-duplicate-validate-model-name branch November 25, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants