fix: sqlite decimal filter error with __gt#2020
Merged
waketzheng merged 6 commits intoNov 27, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #2020 will not alter performanceComparing Summary
|
Pull Request Test Coverage Report for Build 19656027870Details
💛 - Coveralls |
henadzit
reviewed
Nov 24, 2025
| op = filter_info["operator"] | ||
| criterion = op(table[filter_info.get("source_field", filter_info["field"])], value) | ||
| term: Term = table[filter_info.get("source_field", filter_info["field"])] | ||
| if func := field_object and field_object.get_for_dialect( |
Contributor
There was a problem hiding this comment.
Can you please help me to understand why do we need to assign field_object to func?
Contributor
Author
There was a problem hiding this comment.
OK, updated. Code refactored for readability.
henadzit
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2017
Motivation and Context
function_castof DecimalField for sqlite does not used when querying. BUG fixed when this function was called as expected.How Has This Been Tested?
make ci
Checklist: