Fix grouping by in subqueries#2021
Merged
Merged
Conversation
henadzit
force-pushed
the
do-not-add-alias-in-groupby
branch
2 times, most recently
from
November 23, 2025 21:43
e9d895e to
bb266b5
Compare
CodSpeed Performance ReportMerging #2021 will not alter performanceComparing Summary
|
henadzit
force-pushed
the
do-not-add-alias-in-groupby
branch
2 times, most recently
from
November 26, 2025 21:50
0e443e4 to
31110d3
Compare
Pull Request Test Coverage Report for Build 19911400485Details
💛 - Coveralls |
henadzit
force-pushed
the
do-not-add-alias-in-groupby
branch
from
November 26, 2025 22:16
31110d3 to
4d2f03c
Compare
henadzit
changed the title
waketzheng
reviewed
Nov 27, 2025
| _check: | ||
| ruff format --check $(checkfiles) || (echo "Please run 'make style' to auto-fix style issues" && false) | ||
| ruff check $(checkfiles) | ||
| uv run ruff format --check $(checkfiles) || (echo "Please run 'make style' to auto-fix style issues" && false) |
Contributor
There was a problem hiding this comment.
uv run will update the uv.lock
I think it's better to run with --no-sync or set activate-environment to be true, e.g.: waketzheng@a7cad2e
Contributor
Author
There was a problem hiding this comment.
I don't think it will. The run should use the existing lock file.
Contributor
There was a problem hiding this comment.
I don't think it will. The
runshould use the existing lock file.
Imagine that you are using another mirror instead of pypi.org, for example:
export UV_DEFAULT_INDEX=https://mirrors.cloud.tencent.com/pypi/simple/
make _check
Contributor
Author
There was a problem hiding this comment.
You're right! I didn't realize uv sync would update the lock file by default. I added --frozen which seems to be a good way to keep using the lock.
henadzit
force-pushed
the
do-not-add-alias-in-groupby
branch
from
November 29, 2025 21:10
4d2f03c to
501b997
Compare
henadzit
force-pushed
the
do-not-add-alias-in-groupby
branch
from
December 3, 2025 22:49
1d86a20 to
d49dbec
Compare
waketzheng
approved these changes
Dec 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Fixes #1999.
How Has This Been Tested?
ci
Checklist: