Skip to content

feat: support pathlib.Path as argument of TortoiseConfig.from_config_file#2184

Open
waketzheng wants to merge 3 commits intotortoise:developfrom
waketzheng:feat/support-Path-as-config-file
Open

feat: support pathlib.Path as argument of TortoiseConfig.from_config_file#2184
waketzheng wants to merge 3 commits intotortoise:developfrom
waketzheng:feat/support-Path-as-config-file

Conversation

@waketzheng
Copy link
Copy Markdown
Contributor

Description

To support Path as argument of TortoiseConfig.from_config_file/resolve_args, for example:

from pathlib import Path

filepath = Path('/path/to/config.json')
config = TortoiseConfig.from_config_file(filepath)
config2 = TortoiseConfig.resolve_args(config_file=filepath)

assert config == config2 == TortoiseConfig.from_config_file(str(filepath))

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 1, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing waketzheng:feat/support-Path-as-config-file (60755b6) with develop (9d0e53e)

Open in CodSpeed

@waketzheng waketzheng requested a review from abondar May 1, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant