Skip to content

Conversation

@hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Nov 6, 2024

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/PD-4084

Description

  • Convert JS tests -> Typescript tests
  • Use Vitest
  • Remove Karma + mocha
  • Update command

How has this been tested?

Run npm run test:all
CI runner on GitHub Action

Screenshots (if appropriate):

Screenshot 2024-11-07 at 01 21 39

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@hieu-w hieu-w marked this pull request as ready for review November 6, 2024 18:21
@hieu-w hieu-w requested a review from chaitanyapotti November 7, 2024 02:42
hieu-w and others added 6 commits November 12, 2024 22:26
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 862720b into master Nov 25, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/PD-4084-Update-typescript-test branch November 25, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants