Fix #21 and #28#37
Open
maiertech wants to merge 8 commits intototocaster:masterfrom
maiertech:issue-28
Open
Conversation
This was referenced Sep 6, 2016
woodyrew
reviewed
Sep 25, 2016
woodyrew
left a comment
There was a problem hiding this comment.
Only use lodash.sortby rather than the whole package.
| @@ -1,210 +1,143 @@ | |||
|
|
|||
| var _ = require('lodash'); | |||
There was a problem hiding this comment.
Rather than including the whole of lodash, it would be good to include the packages needed.
e.g.
var sortBy = require('lodash.sortby');and amend line 87 to match the variable name.
| }, | ||
| "dependencies": { | ||
| "slug": "^0.9.1" | ||
| "lodash": "^4.15.0", |
There was a problem hiding this comment.
Don't forget to change the dependency too:
"lodash.sortby": "^4.7.0"
|
@mdotasia Can you rebase to resolve the conflicts? |
Collaborator
|
@mdotasia if you can rebase and resolve the conflicts, we'll get this PR merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #28 and presumably #21:
metalsmith-collections.index.jsand used variable names that make reading and understanding the code easier.filesand verify anything I want to verify regarding the tag pages.tagsfor pages has now the same structure as the globaltags. This is to ensure that I can re-use a layout partial to display all tags or only page tags without having to modify how to accesstagandurlSafe. This might conflict with PR Add a tagsCollection object holding a display & url safe tag label #34.skipMetadataoption. It looked to me that it did not save much processing because the plugin still needs to create the globaltagsdata structure.