[ext] YouTube history import: fix compatibility with Chrome

browser-extension/src/background.js

@@ -123,7 +123,7 @@ chrome.runtime.onMessage.addListener((request, sender, sendResponse) => {
   }
 
   if (request.message == 'addRateLaterBulk') {
-    addRateLaterBulk(request.videoIds).then(sendResponse).catch(sendResponse);
+    addRateLaterBulk(request.videoIds).then(sendResponse);
     return true;
   }
 

browser-extension/src/browserAction/menu.js

@@ -109,7 +109,7 @@ function openOptionsPage() {
 }
 
 function rateLaterHistory() {
-  browser.tabs.create({
+  chrome.tabs.create({
     url: 'https://www.youtube.com/feed/history',
   });
 }

browser-extension/src/rateLaterHistory.js

@@ -178,10 +178,11 @@ const addRateLaterBulk = async (videoIds) =>
         videoIds,
       },
       (response) => {
-        if (response === undefined)
-          reject(new Error('addRateLaterBulk failed'));
-        else if (response instanceof Error) reject(response);
-        else resolve(response);
+        if (response.success) {
+          resolve(response.body);
+        } else {
+          reject(response);
+        }
       }
     );
   });
@@ -258,7 +259,7 @@ const addVideoIdsToRateLater = async (videoIds) => {
     } catch (e) {
       console.error(e);
       chunk.forEach((videoId) => failedSet.add(videoId));
-      if (e?.message === 'http429') {
+      if (e?.status === 429) {
         tooManyRequests = true;
         break;
       }
@@ -427,7 +428,10 @@ const addRateLaterHistoryButton = () => {
   const menuContents = document.querySelector(
     'ytd-browse-feed-actions-renderer #contents'
   );
-  menuContents.prepend(button);
+  if (menuContents) {
+    // The menu may not be found yet when the History page is the entry page.
+    menuContents.prepend(button);
+  }
 };
 
 onYoutubeReady(() => {

browser-extension/src/utils.js

@@ -90,22 +90,19 @@ export const addRateLater = async (video_id) => {
 };
 
 export const addRateLaterBulk = async (videoIds) => {
-  const ratingStatusReponse = await fetchTournesolApi(
+  const rateLaterBulkResponse = await fetchTournesolApi(
     'users/me/rate_later/videos/_bulk_create',
     {
       method: 'POST',
       data: videoIds.map((videoId) => ({ entity: { uid: 'yt:' + videoId } })),
     }
   );
-  if (!ratingStatusReponse?.ok) {
-    if (ratingStatusReponse?.status === 429) {
-      throw new Error('http429');
-    } else {
-      throw new Error('addRateLaterBulk request failed');
-    }
-  }
-
-  return await ratingStatusReponse.json();
+  const responseJson = await rateLaterBulkResponse.json();
+  return {
+    success: rateLaterBulkResponse.ok,
+    status: rateLaterBulkResponse.status,
+    body: responseJson,
+  };
 };
 
 /**