Skip to content

Solidago rebuild #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 142 commits into
base: main
Choose a base branch
from
Open

Solidago rebuild #2079

wants to merge 142 commits into from

Conversation

lenhoanglnh
Copy link
Contributor

Related issues: #2031, #2042, #2044


Description

Major rebuild of Solidago.
The goal is to be a lot more readable, maintainable and easy to further develop.
This should facilitate the resolution of issues #2031, #2042, #2044.
The connection interface to Tournesol is also simplified, but has yet to be fully done (in backend/ml).

Checklist

  • I added the related issue(s) id in the related issues section (if any)
  • I described my changes and my decisions in the PR description
  • I read the development guidelines of the CONTRIBUTING.md
  • The tests pass and have been updated if relevant
  • The code quality check pass

❤️ Thank you for your contribution!

Next:
- Re-add Privacy
- Add EmbeddedUser
- Add EmbeddedEntity
- Make generative_model work
Import of tournesol state also functional.

Next step is to develop and verify state import/export.
Generative Model works
Saving Data from Generative Model works
Loading Data from Generative Model works

Next:
- Saving tournesol data (including direct models)
- Pipeline!
Next is the pipeline!
Moving back to pipeline
Loading tiny tournesol now works
Interestingly, requires new methods for state objects
And then tests, tests, tests...
…sol-app/tournesol into solidago_refactor_updatable_state
…sol-app/tournesol into solidago_refactor_updatable_state
Probably due to too many common uses of user_models.
Found a major issue: Pipeline should know which type result to use.
To get there, a useful first step would be to have a non-abstract ScoringModel class.
This helps understand the interface Solidago-Tournesol
Passed tests. Now testing pipeline on TournesolExport.
Next is connecting Tournesol with Solidago.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant