-
-
Notifications
You must be signed in to change notification settings - Fork 50
Solidago rebuild #2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lenhoanglnh
wants to merge
142
commits into
main
Choose a base branch
from
solidago_refactor_updatable_state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Solidago rebuild #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next: - Re-add Privacy - Add EmbeddedUser - Add EmbeddedEntity - Make generative_model work
Import of tournesol state also functional. Next step is to develop and verify state import/export.
Generative Model works Saving Data from Generative Model works Loading Data from Generative Model works Next: - Saving tournesol data (including direct models) - Pipeline!
Next is the pipeline!
Moving back to pipeline
…r Class (NestedDict)
Added plenty of tests
Loading tiny tournesol now works
Interestingly, requires new methods for state objects
… NestedDictOfTuples for cleaner code
And then tests, tests, tests...
…sol-app/tournesol into solidago_refactor_updatable_state
…sol-app/tournesol into solidago_refactor_updatable_state
Probably due to too many common uses of user_models.
Found a major issue: Pipeline should know which type result to use. To get there, a useful first step would be to have a non-abstract ScoringModel class.
This helps understand the interface Solidago-Tournesol
Passed tests. Now testing pipeline on TournesolExport. Next is connecting Tournesol with Solidago.
WIP Polis analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #2031, #2042, #2044
Description
Major rebuild of Solidago.
The goal is to be a lot more readable, maintainable and easy to further develop.
This should facilitate the resolution of issues #2031, #2042, #2044.
The connection interface to Tournesol is also simplified, but has yet to be fully done (in
backend/ml
).Checklist
❤️ Thank you for your contribution!