refactor: update membership pricing to have fee added on top of price #4265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 6, 2025
giuseppecrj
changed the title
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
giuseppecrj
requested review from
jterzis,
pfives and
shuhuiluo
as code owners
giuseppecrj
force-pushed
the
g/10-06-refactor_membership_pricing
branch
from
c15dac5 to
01b3daa
Compare
giuseppecrj
force-pushed
the
g/10-06-membership_small_refactors
branch
from
57d042b to
b6cb8ef
Compare
This was referenced Oct 7, 2025
giuseppecrj
requested review from
erikolsson,
salzbrenner,
sergekh2 and
texuf
as code owners
giuseppecrj
changed the base branch from
g/10-06-membership_small_refactors
to
graphite-base/4265
giuseppecrj
force-pushed
the
g/10-06-refactor_membership_pricing
branch
from
1e8b8ad to
bab6c1c
Compare
giuseppecrj
force-pushed
the
graphite-base/4265
branch
from
b6cb8ef to
15713c4
Compare
giuseppecrj
changed the base branch from
graphite-base/4265
to
g/10-06-membership_small_refactors
giuseppecrj
force-pushed
the
g/10-06-refactor_membership_pricing
branch
from
b32ca60 to
e87d7fb
Compare
giuseppecrj
force-pushed
the
g/10-06-membership_small_refactors
branch
from
15713c4 to
d7e7672
Compare
giuseppecrj
changed the base branch from
g/10-06-membership_small_refactors
to
graphite-base/4265
giuseppecrj
changed the base branch from
graphite-base/4265
to
g/10-06-membership_small_refactors
giuseppecrj
force-pushed
the
g/10-06-refactor_membership_pricing
branch
from
648d596 to
3fc2fef
Compare
…ble naming for layout storage. Update MembershipJoin to streamline join details assignment and improve readability. This enhances code clarity and maintains adherence to coding standards.
… conditional checks and improve code clarity.
…et. Removed redundant price verification and updated functions to calculate total membership payment, enhancing clarity and consistency in pricing calculations.
…ip pricing. Updated join functions to calculate total payment based on current membership price, enhancing consistency across membership transactions and improving code clarity.
### Description Added protocol fee to the `getJoinSpacePriceDetails` method to properly account for the total cost when joining a space. ### Changes - Added `protocolFee` property to the return type of `getJoinSpacePriceDetails` - Updated the method to fetch protocol fee data via multicall - Modified the method to decode and return the protocol fee value - Updated tests to verify that the price includes the protocol fee ### Checklist - [x] Tests added where required - [x] Documentation updated where applicable - [x] Changes adhere to the repository's contribution guidelines
### Description Refactored the `SubscriptionModuleTest` to utilize the `SubscriptionParams` structure for renewal price assertions, enhancing clarity and consistency in test logic. ### Changes - Updated the `_createSubscription` call to return `SubscriptionParams`. - Modified assertions to use `params.renewalPrice` instead of hardcoded values. ### Checklist - [x] Tests updated to reflect changes - [x] Changes adhere to the repository's contribution guidelines
giuseppecrj
force-pushed
the
g/10-06-membership_small_refactors
branch
from
4cd4719 to
e0ad3f1
Compare
giuseppecrj
force-pushed
the
g/10-06-refactor_membership_pricing
branch
from
3fc2fef to
6baf394
Compare
giuseppecrj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the membership pricing and fee calculation logic to improve clarity and consistency. It simplifies how protocol fees are calculated and ensures proper payment distribution between protocol fees and space owner proceeds.
Changes
Membership__PriceTooLowerror as it's no longer needed_getTotalMembershipPayment()to calculate total payment required (base price + protocol fee)Checklist