Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions messages/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@
"runs_status_running": "Running",
"runs_status_completed": "Completed",
"runs_status_failed": "Failed",
"runs_deleteRun": "Delete run",
"runs_status_pending": "Pending",

"analysis_title": "Analysis",
Expand Down
6 changes: 5 additions & 1 deletion src/main/ipc/catalog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from '../db/detections';
import { clearDatabase } from '../db/database';
import { getLocations, getLocationsWithCounts } from '../db/locations';
import { getRunsWithStats } from '../db/runs';
import { getRunsWithStats, deleteRun } from '../db/runs';
import { resolveAll, searchByCommonName } from '../labels/label-service';
import type {
Detection,
Expand Down Expand Up @@ -42,6 +42,10 @@ export function registerCatalogHandlers(): void {
return getRunsWithStats();
});

ipcMain.handle('catalog:delete-run', (_event, id: number) => {
deleteRun(id);
});

ipcMain.handle('catalog:get-detections', (_event, filter: DetectionFilter) => {
// If species filter is set, also resolve common name matches from label service
if (filter.species) {
Expand Down
1 change: 1 addition & 0 deletions src/preload/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const ALLOWED_INVOKE_CHANNELS = new Set([
'clip:get-spectrogram',
'clip:export-region',
'catalog:get-runs',
'catalog:delete-run',
'catalog:get-detections',
'catalog:search-species',
'catalog:get-species-summary',
Expand Down
27 changes: 23 additions & 4 deletions src/renderer/src/lib/components/RunList.svelte
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import { AudioLines, CircleAlert, Loader } from '@lucide/svelte';
import { AudioLines, CircleAlert, Loader, X } from '@lucide/svelte';
import { formatDate } from '$lib/utils/format';
import type { RunWithStats } from '$shared/types';
import * as m from '$paraglide/messages';
Expand All @@ -8,11 +8,13 @@
runs,
selectedRunId,
onselect,
ondelete,
loading = false,
}: {
runs: RunWithStats[];
selectedRunId: number | null;
onselect: (runId: number) => void;
ondelete?: (runId: number) => void;
loading?: boolean;
} = $props();

Expand Down Expand Up @@ -45,13 +47,30 @@
</div>
{:else}
{#each runs as run (run.id)}
<button
<div
onclick={() => {
onselect(run.id);
}}
class="border-base-300 w-full border-b px-3 py-2.5 text-left transition-colors
onkeydown={(e) => {
if (e.key === 'Enter' || e.key === ' ') onselect(run.id);
}}
role="button"
tabindex="0"
class="border-base-300 relative w-full cursor-pointer border-b px-3 py-2.5 text-left transition-colors
{selectedRunId === run.id ? 'bg-primary/10 border-l-primary border-l-2' : 'hover:bg-base-300/50'}"
>
{#if run.status === 'failed' && ondelete}
<button
onclick={(e) => {
e.stopPropagation();
ondelete(run.id);
}}
class="text-base-content/30 hover:text-error absolute top-1.5 right-1.5 rounded p-0.5 transition-colors"
title={m.runs_deleteRun()}
>
<X size={14} />
</button>
{/if}
<div class="truncate text-sm font-medium">{sourceName(run.source_path)}</div>
<div class="text-base-content/50 mt-0.5 flex items-center gap-1.5 text-xs">
<span class="truncate">{run.model}</span>
Expand All @@ -75,7 +94,7 @@
</span>
{/if}
</div>
</button>
</div>
{/each}
{/if}
</div>
Expand Down
4 changes: 4 additions & 0 deletions src/renderer/src/lib/utils/ipc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ export function getRuns(): Promise<RunWithStats[]> {
return window.birda.invoke('catalog:get-runs') as Promise<RunWithStats[]>;
}

export function deleteRun(id: number): Promise<void> {
return window.birda.invoke('catalog:delete-run', id) as Promise<void>;
}

export function getDetections(filter: DetectionFilter): Promise<{ detections: EnrichedDetection[]; total: number }> {
return window.birda.invoke('catalog:get-detections', filter) as Promise<{
detections: EnrichedDetection[];
Expand Down
23 changes: 21 additions & 2 deletions src/renderer/src/pages/DetectionsPage.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import RunList from '$lib/components/RunList.svelte';
import AnalysisTable from '$lib/components/AnalysisTable.svelte';
import { appState } from '$lib/stores/app.svelte';
import { getRuns, getDetections } from '$lib/utils/ipc';
import { getRuns, getDetections, deleteRun, getCatalogStats } from '$lib/utils/ipc';
import { formatNumber, parseRecordingStart } from '$lib/utils/format';
import type { EnrichedDetection, RunWithStats } from '$shared/types';
import { onMount } from 'svelte';
Expand Down Expand Up @@ -68,6 +68,19 @@
appState.selectedRunId = runId;
}

async function handleRunDelete(runId: number) {
try {
await deleteRun(runId);
runs = runs.filter((r) => r.id !== runId);
if (appState.selectedRunId === runId) {
appState.selectedRunId = null;
}
appState.catalogStats = await getCatalogStats();
} catch {
// silently ignore — run may already be gone
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Silently ignoring errors in this catch block can lead to a poor user experience and make debugging difficult. If deleteRun() fails for a reason other than the run already being gone (e.g., a database error), the user won't be notified and the UI won't update, which can be confusing. Furthermore, if deleteRun() succeeds but getCatalogStats() fails, the error is also swallowed, leaving the UI in an inconsistent state where the run is removed from the list but the stats are not updated.

It's recommended to at least log the error for debugging purposes. Providing user-facing feedback on failure would be an even better improvement.

    } catch (error) {
      console.error('Failed to delete run ' + runId + ':', error);
      // TODO: Show a user-facing error message.
    }

}

function handleSort(column: string) {
if (sortColumn === column) {
sortDir = sortDir === 'asc' ? 'desc' : 'asc';
Expand Down Expand Up @@ -135,7 +148,13 @@
</script>

<div class="flex flex-1 overflow-hidden">
<RunList {runs} selectedRunId={appState.selectedRunId} onselect={handleRunSelect} loading={runsLoading} />
<RunList
{runs}
selectedRunId={appState.selectedRunId}
onselect={handleRunSelect}
ondelete={handleRunDelete}
loading={runsLoading}
/>

{#if appState.selectedRunId && selectedRun}
<div class="flex flex-1 flex-col overflow-hidden">
Expand Down
Loading