-
Notifications
You must be signed in to change notification settings - Fork 34
feat: parrallel evaluations #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
distributedstatemachine
wants to merge
14
commits into
dev
Choose a base branch
from
feat/parallel_evals
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c9aab44
feat: parrallel evaluations
distributedstatemachine 03958f1
chore: lints + update ecossytem.js
distributedstatemachine 8f7244a
chore: remove import
distributedstatemachine b2a9494
fix: hparam
distributedstatemachine 377c3c9
chore: review comments
distributedstatemachine dc0bba3
fix: evaluation.py
distributedstatemachine 59e8611
fix: evaluation , validator
distributedstatemachine d3a3e4e
fix: update r2 dataset
distributedstatemachine 9124e08
feat: batch tokenization
distributedstatemachine 5050ffc
fix: nom bin indicator
distributedstatemachine 759b59a
chore: ruff
distributedstatemachine fd8ad5a
fix: per shard locks
distributedstatemachine 78081b6
chore: TYPES!?!?!
distributedstatemachine e05cca4
chore: ruff
distributedstatemachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why hparams before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also curious what the reason to lower minimum peers was?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing locally , should have put this in draft it wasnt ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why hparams before?
i dont understand this , can you please rephrase your questionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Why prefix parallel eval uids with
hparams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its how it currently works , we have a max uids to evals in the window, this tell us how many of them should be parrallel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not call it
parallel_eval_uids
instead ofhparams.parallel_eval_uids
?