Skip to content

centralize action controls and styles in AllDataSelection#1072

Open
CamilleGuillory wants to merge 2 commits into
tprouvot:releaseCandidatefrom
CamilleGuillory:issue/Align-Flow-Buttons
Open

centralize action controls and styles in AllDataSelection#1072
CamilleGuillory wants to merge 2 commits into
tprouvot:releaseCandidatefrom
CamilleGuillory:issue/Align-Flow-Buttons

Conversation

@CamilleGuillory
Copy link
Copy Markdown
Contributor

PR to fix this alignment issue:
image

Describe your changes

  • Introduce reusable action helpers (actionWrapper, actionLink, actionButton) with shared SLDS classes
  • Replace repeated anchor/button markup with helpers for deploy status, package.xml, flow tools, and API action buttons
  • Wrap actions in a dedicated container (sfir-all-data-actions)

Why: Reduces duplicated JSX, enforces consistent styling/attributes (e.g., target/data-target-link), and simplifies future maintenance of action buttons.

Checklist before requesting a review

  • I have read and understand the Contributions section
  • Target branch is releaseCandidate and not master
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

@CamilleGuillory
Copy link
Copy Markdown
Contributor Author

After the fix:
image

  • Resolves margin-left issue
  • Ensures consistent bottom margin (slds-m-bottom_xx-small) between buttons

@CamilleGuillory CamilleGuillory force-pushed the issue/Align-Flow-Buttons branch 2 times, most recently from 64034b3 to 7a9f1ad Compare February 6, 2026 21:04
@CamilleGuillory
Copy link
Copy Markdown
Contributor Author

CamilleGuillory commented Feb 6, 2026

@tprouvot ready for review.
Note: the GitHub file diff looks weird. The changes are easier to understand when viewed locally.

@CamilleGuillory CamilleGuillory force-pushed the issue/Align-Flow-Buttons branch from 7a9f1ad to 6ea40aa Compare May 5, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant