Feat/tab component & reuse accross pages#1118
Open
CamilleGuillory wants to merge 8 commits into
Open
Conversation
- Added a new `TabBar` component to support dynamic, editable, and closable tabs, improving user experience in managing queries. - Integrated the `TabBar` into the data export interface, replacing static tab elements for better functionality. - Updated styles in `TabBar.css` to align with SLDS guidelines and enhance visual consistency. - Refactored related components to utilize the new `TabBar`, ensuring seamless interaction and state management across tabs.
- Introduced a `ButtonMenu` component for improved dropdown menu functionality, allowing for better user interaction with menu items. - Updated `inspect.css` and `options.css` to include new styles for the sticky tab bar and button menu, enhancing visual consistency and usability. - Refactored existing components to integrate the new `ButtonMenu`, replacing static elements for a more dynamic experience. - Improved layout and styling for tab controls and filter options in the inspect page, ensuring a cohesive design across the application.
- Modified the TabBar component to conditionally render the close button based on the number of tabs, enhancing user experience by preventing unnecessary actions when only one tab is present. - Updated documentation for the Data Export page to clarify tab closing options, including middle-click functionality and visibility conditions for the close button.
…idation error handling - Enhanced the ButtonMenu component with keyboard navigation and focus management - Added new styles for error messages and button interactions
CamilleGuillory
force-pushed
the
feat/Tab-Component-&-Reuse-accross-pages
branch
from
c9fc991 to
610d7d2
Compare
…ors with TabBar - Make the global filter on the Inspect page apply on every tab (previously it only worked on the "all" tab); per-column filters still layer on top - Update inspect and options e2e tests to target the new TabBar markup (li[role='tab'][data-aspect=...], .slds-tabs_scoped__nav) and the renamed "Global Filter" input - Extend the Filter Fields test to assert the global filter remains effective after switching to the Fields tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New components
TabBar (
addon/components/TabBar.js)ButtonMenu (
addon/components/ButtonMenu.js)lightning-button-menu.Reuse across pages
Images
Date export tabs:
Option tabs:
Popup tabs:
Show all date (inspec) tabs & dropdown:
Styling
addon/components/TabBar.css.addon/styles/sfir.css.Checklist before requesting a review