Skip to content

Conversation

@pawurb
Copy link
Contributor

@pawurb pawurb commented Nov 24, 2025

Hi, I've deprecated channels-console, it's now part of hotpath. I'm continously working on improving the lib so any feedback and bug reports will be appreciated!

@tqwewe
Copy link
Owner

tqwewe commented Nov 25, 2025

Great thanks for making this PR, and hotpath itself!

The 2 tests which change behaviour based on hotpath feature being enabled fail, I assume because it needs to take into account hotpath-off.

I'm also curious about hotpath-alloc. Is that worth having within kameo, does it affect the channel monitoring?

@pawurb
Copy link
Contributor Author

pawurb commented Nov 25, 2025

Hi, hotpath-alloc does not affect channel! macro only enables mem profiling for functions if you use hotpath::measure. And yes, for --all-features hotpath-off flag causes all macros to be no-op.

@tqwewe
Copy link
Owner

tqwewe commented Nov 26, 2025

Since we're not using hotpath::measure here, I don't think we need to add the hotpath-alloc feature flag in kameo

@tqwewe
Copy link
Owner

tqwewe commented Nov 26, 2025

I've removed hotpath-alloc and hotpath-off features to keep things simple. If users want to have hotpath-alloc enabled, then they can easily enable it in their own hotpath dependency and use hotpath::measure as needed.

@tqwewe tqwewe merged commit aa47b39 into tqwewe:main Nov 26, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants