Merged
Conversation
Contributor
|
Preview (prod backend + PR dashboard) → https://1151.ns-preview.trapti.tech/ |
Contributor
Author
|
ビルド結果抜粋 containers:
- name: dashboard
image: ghcr.io/traptitech/ns-dashboard:main
imagePullPolicy: Always
ports:
- name: http
containerPort: 80
resources:
limits:
cpu: 100m
memory: 50Mi
requests:
cpu: 10m
memory: 10Mi |
There was a problem hiding this comment.
Pull request overview
This PR fixes the location and structure of the resources block in the ns-dashboard Helm deployment template so that it renders valid Kubernetes manifests aligned with the other components’ deployments.
Changes:
- Wraps the dashboard container resource configuration in a
resources:key. - Corrects the indentation of the
resourcesblock to match other component deployments (builder, gateway, controller).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pirosiki197
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜやるか
ns-dashboardのHelm templateにおいて、resourcesを配置する位置が誤っていたために不正なmanifestが出力されていたため。やったこと
resourcesを適切な位置に挿入するようにやらなかったこと
特になし
資料
values.yaml該当箇所: https://github.com/traPtitech/manifest/blob/88affcebdfb1bda6b1371e39a30dc95f203f1c9d/ns-dev-system/values.yaml#L180-L186