Skip to content

resourcesの配置位置を修正#1151

Merged
Kentaro1043 merged 1 commit intomainfrom
fix/helm-dashboard-resources
Jan 23, 2026
Merged

resourcesの配置位置を修正#1151
Kentaro1043 merged 1 commit intomainfrom
fix/helm-dashboard-resources

Conversation

@Kentaro1043
Copy link
Copy Markdown
Contributor

なぜやるか

ns-dashboardのHelm templateにおいて、resourcesを配置する位置が誤っていたために不正なmanifestが出力されていたため。

やったこと

resourcesを適切な位置に挿入するように

やらなかったこと

特になし

資料

values.yaml該当箇所: https://github.com/traPtitech/manifest/blob/88affcebdfb1bda6b1371e39a30dc95f203f1c9d/ns-dev-system/values.yaml#L180-L186

Copilot AI review requested due to automatic review settings January 23, 2026 05:22
@github-actions
Copy link
Copy Markdown
Contributor

Preview (prod backend + PR dashboard) → https://1151.ns-preview.trapti.tech/

@Kentaro1043
Copy link
Copy Markdown
Contributor Author

ビルド結果抜粋

      containers:
        - name: dashboard
          image: ghcr.io/traptitech/ns-dashboard:main
          imagePullPolicy: Always
          ports:
            - name: http
              containerPort: 80
          resources:
            limits:
              cpu: 100m
              memory: 50Mi
            requests:
              cpu: 10m
              memory: 10Mi

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the location and structure of the resources block in the ns-dashboard Helm deployment template so that it renders valid Kubernetes manifests aligned with the other components’ deployments.

Changes:

  • Wraps the dashboard container resource configuration in a resources: key.
  • Corrects the indentation of the resources block to match other component deployments (builder, gateway, controller).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Kentaro1043 Kentaro1043 merged commit f427e86 into main Jan 23, 2026
21 checks passed
@Kentaro1043 Kentaro1043 deleted the fix/helm-dashboard-resources branch January 23, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants