feat: enhance structured logging with service context and dynamic levels#1168
Merged
pirosiki197 merged 1 commit intomainfrom Mar 8, 2026
Merged
feat: enhance structured logging with service context and dynamic levels#1168pirosiki197 merged 1 commit intomainfrom
pirosiki197 merged 1 commit intomainfrom
Conversation
Contributor
|
Preview (prod backend + PR dashboard) → https://1168.ns-preview.trapti.tech/ |
|
Caution Review failedPull request was closed or merged during review 📝 Walkthroughウォークスルーロギングの初期化フローを再構成し、main関数での早期初期化から、根コマンドのPersistentPreRunでのサービス名に基づく遅延初期化に変更しました。InitLoggerの署名を変更してサービスメタデータを受け取り、ランタイムレベル調整にSetLogLevelを導入し、PrintVersionファンクションを削除しました。 変更内容
推定コード審査工数🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜやるか
ログに
service.nameやservice.versionがあると、見たときにわかりやすいやったこと
service.nameやservice.versionをログに含めたやらなかったこと
資料
Summary by CodeRabbit
リリースノート
New Features
Refactor