BlueskyをAccountTypeに追加#745
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 70.77% 70.66% -0.12%
==========================================
Files 43 43
Lines 4572 4578 +6
==========================================
- Hits 3236 3235 -1
- Misses 1183 1188 +5
- Partials 153 155 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ras0q
reviewed
Jan 14, 2025
Comment on lines
-407
to
+408
| httpError(t, "Bad Request: validate error: type: must be no greater than 11."), | ||
| httpError(t, fmt.Sprintf("Bad Request: validate error: type: must be no greater than %d.", domain.AccountLimit-1)), |
Comment on lines
-407
to
+408
| httpError(t, "Bad Request: validate error: type: must be no greater than 11."), | ||
| httpError(t, fmt.Sprintf("Bad Request: validate error: type: must be no greater than %d.", domain.AccountLimit-1)), |
Merged
Pugma
approved these changes
Jul 1, 2025
Pugma
left a comment
Pugma
left a comment
Contributor
There was a problem hiding this comment.
公式情報もなさそうですし、とりあえずはこちらの正規表現で問題ないかと思います
もし不具合があればその際に対応する形で問題ないかと思います
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #738
Blueskyのプロフィールリンクの正規表現が見つからなかったのでいろいろ試してこれに落ち着きました
多分大丈夫だと思います