Skip to content

Users以外にlimitを追加#764

Merged
gurukun41 merged 2 commits into
mainfrom
feat/add-limit-parameter
Jul 18, 2025
Merged

Users以外にlimitを追加#764
gurukun41 merged 2 commits into
mainfrom
feat/add-limit-parameter

Conversation

@gurukun41

Copy link
Copy Markdown
Contributor

close #90

eventsのスキーマにlimitを追加していますが、eventsではknoQ側のAPIにlimitがなかったため実装はしていません。

@codecov

codecov Bot commented Jul 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.64%. Comparing base (8f2c965) to head (46c39d9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/handler/contest.go 66.66% 2 Missing and 1 partial ⚠️
internal/handler/group.go 66.66% 2 Missing and 1 partial ⚠️
internal/handler/project.go 66.66% 2 Missing and 1 partial ⚠️
internal/infrastructure/repository/group_impl.go 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   71.00%   70.64%   -0.37%     
==========================================
  Files          43       43              
  Lines        4584     4623      +39     
==========================================
+ Hits         3255     3266      +11     
- Misses       1171     1198      +27     
- Partials      158      159       +1     
Flag Coverage Δ
integration 70.64% <75.00%> (-0.37%) ⬇️
unit 70.64% <75.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@H1rono H1rono left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
質問がなければマージしてください

@gurukun41
gurukun41 merged commit 2c25ed5 into main Jul 18, 2025
13 of 14 checks passed
@gurukun41
gurukun41 deleted the feat/add-limit-parameter branch July 18, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

一覧系APIでlimitを指定できるようにする

2 participants