-
Notifications
You must be signed in to change notification settings - Fork 43
リアクションをホバーしたときに拡大して表示 #4434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+295
−59
Merged
リアクションをホバーしたときに拡大して表示 #4434
Changes from 3 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
c1c88b5
リアクションのホバー時に拡大表示する機能の追加
8d05380
ホバー時、リアクションした人も分かるように
acd6832
format
Pugma 0101b00
titleを削除
ec87df5
aria-label属性を追加(フォーマットはDiscordに合わせた)
e50a748
rum formatで引っかかったので修正
6bbdefe
コードを整形
7c3878d
ポップアップが画面の端に来ると表示が壊れる不具合の修正およびポップアップがツールバーより上に来るように修正
UnABC dfe59a5
リアクションした人数が多い場合に「他n人」と圧縮
UnABC 2544496
リアクションした人一覧で余分な空白が出来る問題を軽減
UnABC 862f88f
ホバーした0.5秒後にポップアップが出るように調整
UnABC 5ee9bac
formatの調整
UnABC 108c4c1
モバイル版においてホバーによる拡大を無効化
b5850d4
StampScaledDetailElementのspan要素をscript部で記述など
UnABC 3a771c4
ポップアップをDiscordと同じような感じに変更
UnABC 646c014
conflictの解消
UnABC f19b322
拡大表示内容に誤りがあったので修正
UnABC 5087384
format
UnABC e379fa0
画面端で見切れる問題を修正、UIの微調整
UnABC b84cbfa
Merge branch 'master' into issue4299
Pugma 2b99e5e
Merge branch 'master' of github.com:traPtitech/traQ_S-UI into issue4299
UnABC cbc515e
UIの調整
UnABC 995cfd7
ユーザアイコン表示の上限を100→30に変更等
UnABC 6e8dce7
ユーザアイコン表示の上限を100→32に変更等
UnABC 167ff71
isLongHoverd判定ロジック追加等
UnABC 534fe15
Merge branch 'issue4299' of github.com:traPtitech/traQ_S-UI into issu…
UnABC 672c119
UIの調整
UnABC 8ec935b
間隔、サイズ等の調整
UnABC ae54378
UIの微調整
UnABC 974d348
コードの整理
UnABC 02c6f74
コードの微調整
UnABC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
src/components/Main/MainView/MessageElement/StampScaledElement.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<template> | ||
<div v-show="show" :class="$style.scaleReaction"> | ||
<transition name="scale-reaction"> | ||
<!-- sizeを46より大きくすると見切れる --> | ||
<a-stamp | ||
:key="stamp.id" | ||
:stamp-id="stamp.id" | ||
:size="46" | ||
:class="$style.stamp" | ||
without-title | ||
/> | ||
</transition> | ||
<stamp-detail-element :class="$style.detail" :stamp="stamp" /> | ||
</div> | ||
</template> | ||
|
||
<script lang="ts" setup> | ||
import AStamp from '/@/components/UI/AStamp.vue' | ||
import type { MessageStampById } from '/@/lib/messageStampList' | ||
import StampDetailElement from './StampDetailElement.vue' | ||
|
||
const props = defineProps<{ | ||
stamp: MessageStampById | ||
show: boolean | ||
}>() | ||
</script> | ||
|
||
<style lang="scss" module> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ここ、grid の中の item で margin を入れてて margin が 2 つ分できてしまってるので、 flex box にして gap 指定する形で margin 重複を回避できるならしたいかも |
||
.scaleReaction { | ||
@include color-ui-tertiary; | ||
@include background-primary; | ||
display: flex; | ||
border-radius: 4px; | ||
contain: none; | ||
flex-wrap: wrap; | ||
border: solid 2px $theme-ui-tertiary-default; | ||
} | ||
.stamp { | ||
margin: { | ||
right: 0.2rem; | ||
bottom: 0.2rem; | ||
} | ||
display: flex; | ||
} | ||
|
||
.detail { | ||
color: var(--specific-count-text); | ||
@include color-ui-primary; | ||
max-width: 500px; | ||
min-width: 0; | ||
overflow: hidden; | ||
overflow: clip; | ||
margin: { | ||
left: 6px; | ||
right: 4px; | ||
} | ||
} | ||
</style> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.