Adding support for GCE discovery #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for this! |
Contributor
|
@sammerry sorry for the late feedback. There is already a mechanism for installing plugins in this playbook. Was there a specific reason for creating a new task? From what I can tell, only elasticsearch.yml.j2 really needs changes. |
Author
|
The GCE plugin templates were added to mirror the AWS template style. Really the change that needs to happen is in |
Contributor
|
@sammerry ok I see. The installation of the AWS plugin in the playbook predates the support for generic plugins. I need to refactor it to be consistent with the generic plugin mechanism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for GCE discovery. Im in the process of testing this at the moment but would like feedback.