Define NOMINMAX and various warning suppressions on MSVC - #707
Open
fredemmott wants to merge 4 commits into
Open
Define NOMINMAX and various warning suppressions on MSVC#707fredemmott wants to merge 4 commits into
NOMINMAX and various warning suppressions on MSVC#707fredemmott wants to merge 4 commits into
Conversation
- disable unwanted/irrelevant warnings - define `NOMINMAX` so windows headers don't break `std::min()` and `std::max()` calls refs trabucayre#704
The real `<Windows.h>` pulls in a load of stuff, and defines a lot of lower-case macros, e.g. `byte`, which with `using namespace std`, leads to conflicts with `std::byte` refs trabucayre#704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on (and includes) #706
I've kept the
(bool > 0)thing as a separate commit as I'm unsure if your(_verbose > 0)checks are are a bug or if they're future-proofing in case of multiple verbosity levels in the future.