-
Notifications
You must be signed in to change notification settings - Fork 580
Adding bitwise ops #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding bitwise ops #3120
Conversation
…tensor types in bitwise operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the scalar case is not correctly handled (see CI errors).
Also, the ONNX tests refactor in #3144 (merged) have introduced a minor conflict with the removal of the test_onnx.rs
file.
All major reorg refactoring is done. Let me know if you need to help with merging. Please see updated book section: cargo xtask books contributor open You can also pick into a recent PR merged with tests/configuration locations: #3177 |
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1714
Changes
Developed the bitwise operators in burn while following the steps from the contributor book:
BitShift
BitwiseAnd
BitwiseNot
BitwiseOr
BitwiseXor
Testing
Developed unit tests for each of the bitwise operators.