Skip to content

Adding bitwise ops #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Adding bitwise ops #3120

wants to merge 21 commits into from

Conversation

AshAnand34
Copy link
Contributor

@AshAnand34 AshAnand34 commented Apr 30, 2025 •
edited
Loading

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1714

Changes

Developed the bitwise operators in burn while following the steps from the contributor book:

  • BitShift
  • BitwiseAnd
  • BitwiseNot
  • BitwiseOr
  • BitwiseXor

Testing

Developed unit tests for each of the bitwise operators.

AshAnand34 and others added 18 commits April 28, 2025 20:29
@AshAnand34
Started integrating bitwise operators to burn
e6b1e5f
@AshAnand34
Started developing the bitwise operators for burn
a62cc9c
@AshAnand34
Created python files to create test ONNX models for the bitwise opera…
8f00bdc 
…tors
@AshAnand34
Fixing bitshift.rs to account for direction
2dbe899
@AshAnand34
Merge remote-tracking branch 'origin/main' into adding-bitwise-ops
5378d38
@AshAnand34
Added test onnx files to build and added rank inference for the bitwi…
48c3aa9 
…se operations.
@AshAnand34
Made fixes to test onnx files due to wrong node inits and restricted …
4b91855 
…tensor types in bitwise operations
@AshAnand34
Fixed test_onnx.rs to include the right onnx file names for bitshift
8d997f9
@AshAnand34
Created onnx model tests for bitwise operators
69d61c7
@AshAnand34
rank fixing
3fce6eb
@AshAnand34
Fixed unit tests for bitwise operators
e867f61
@AshAnand34
More unit test fixes in bitwise operators
5b57b09
@AshAnand34
created onnx files for scalar versions of the bitwise operators
6420833
@AshAnand34
Integrated scalar versions of onnx model to the onnx tests
dccbc2a
@AshAnand34
Added scalar argtypes to to_burn
60599d0
@AshAnand34
Merge branch 'tracel-ai:main' into adding-bitwise-ops
92603ab
@AshAnand34
Added bitshift config plus minor fixes
fa5574f
@AshAnand34
Merge branch 'tracel-ai:main' into adding-bitwise-ops
871f295
@antimora antimora added the onnx label May 5, 2025
@AshAnand34 AshAnand34 marked this pull request as ready for review May 7, 2025 06:20
laggui
laggui reviewed May 8, 2025
View reviewed changes
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the scalar case is not correctly handled (see CI errors).

Also, the ONNX tests refactor in #3144 (merged) have introduced a minor conflict with the removal of the test_onnx.rs file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laggui laggui laggui left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
onnx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshAnand34 @laggui @antimora