Skip to content

Add support onnx ceil & round #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

tye-singwa
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that cargo run-checks command has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1714

Changes

Adding ceil & round onnx support

Testing

Added tests

Copy link

codecov bot commented May 25, 2025

Codecov Report

Attention: Patch coverage is 99.39759% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (c51045c) to head (0b03514).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-autodiff/src/ops/tensor.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
+ Coverage   82.14%   82.15%   +0.01%     
==========================================
  Files         966      970       +4     
  Lines      123257   123421     +164     
==========================================
+ Hits       101247   101402     +155     
- Misses      22010    22019       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! 🙂

This could have been implemented simply as a unary node, but I see that the floor node is also implemented as a separate node. LGTM then! We can simplify in a follow-up PR if needed.

@laggui laggui merged commit 6e15d87 into tracel-ai:main May 30, 2025
11 checks passed
@tye-singwa tye-singwa deleted the onnx-ceil-round branch May 30, 2025 15:19
@antimora
Copy link
Collaborator

@laggui I want to confirm if this autodiff fix is correct.

I have had a pending comment that I forgot to submit

@laggui
Copy link
Member

laggui commented Jun 2, 2025

@laggui I want to confirm if this autodiff fix is correct.

I have had a pending comment that I forgot to submit

Yeah the autodiff implementation previously returned the result with floor for the output (though the gradients were fine). Slipped through the cracks it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants