feat(cubecl): wire logical any/all reductions#5051
Open
zhan-wei-919 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
Depends on tracel-ai/cubek#302
Related with #5046
Changes
This PR wires Burn's CubeCL backend to cubek's logical
any/allreductions.Changes include:
cubekto the cubek PR commit from feat(reduce): add logical any/all reductions cubek#302cubecl,cubecl-common, andcubecl-zspaceto the matching cubek dependency revisionbool_any/bool_allfloat_any/float_allint_any/int_allReduceOperationConfig::Any/Allany_dim/all_dimGlobalMemoryStrategyinitialization to the newer cubek interpolate APIThis makes Burn's
contains_nan()path use a real logical reduction throughis_nan().any()on CubeCL instead of relying on sum based behavior.Testing