Merged
Conversation
2 tasks
nathanielsimard
requested changes
Mar 18, 2026
Comment on lines
+37
to
+43
| let guard = self.lock.lock.lock(); | ||
| let map = guard.map.borrow(); | ||
| let state = map.get(&TypeId::of::<S>()).unwrap(); | ||
| let utilities = state.utilities.clone(); | ||
| core::mem::drop(map); | ||
| core::mem::drop(guard); | ||
| utilities |
Member
There was a problem hiding this comment.
No need for the self.lock, this is not mutable.
Comment on lines
+281
to
+284
| assert_eq!( | ||
| src.stream, dst.stream, | ||
| "Source and destination should be on the same stream." | ||
| ); |
Member
There was a problem hiding this comment.
Instead of panic, I would add an error to each stream and return.
nathanielsimard
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate your PR with burn.
It is important that you make sure that you don't introduce any bugs in burn.
Instructions
Burn PR : tracel-ai/burn#4640