Skip to content

feat: Allow view layouts to infer launch info from buffer metadata#1231

Merged
wingertge merged 5 commits intotracel-ai:mainfrom
wingertge:refactor/view-launch
Mar 17, 2026
Merged

feat: Allow view layouts to infer launch info from buffer metadata#1231
wingertge merged 5 commits intotracel-ai:mainfrom
wingertge:refactor/view-launch

Conversation

@wingertge
Copy link
Collaborator

Adds a new ViewLayoutLaunchArg trait that allows for a more specialized launch logic on views, inferring metadata from the buffer instead of passing everything explicitly. All LaunchArgs implement this trait automatically, and a new ConcreteLayout wrapper allows launching ViewLayoutLaunchArgs separately, with manually provided shapes/strides.

Moves FastDivmod initialization from the arg creation to registration, so it no longer needs the client and can instead use the device_properties on the scope to detect feature support.

Validate your PR with burn.

It is important that you make sure that you don't introduce any bugs in burn.

Instructions

  • Create a new branch or fork of the burn repo
  • Update the main Cargo.toml with this PR hash.
  • Fix any broken tests or compilation errors in burn.
  •  Submit a PR in burn with your fixes and link it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wingertge wingertge merged commit a9e0a8a into tracel-ai:main Mar 17, 2026
5 checks passed
@wingertge wingertge deleted the refactor/view-launch branch March 17, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants