refactor: Merge compilation_arg and register#1237
Merged
nathanielsimard merged 2 commits intotracel-ai:mainfrom Mar 21, 2026
Merged
refactor: Merge compilation_arg and register#1237nathanielsimard merged 2 commits intotracel-ai:mainfrom
compilation_arg and register#1237nathanielsimard merged 2 commits intotracel-ai:mainfrom
Conversation
nathanielsimard
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans things up and makes them less fragile by ensuring registration and expand are more closely tied together via the compilation arg. This was primarily an issue with
FastDivmodandLinearLayout, where the registration and compilation arg were repeating the same detection on different scopes.Validate your PR with burn.
It is important that you make sure that you don't introduce any bugs in burn.
Instructions