Handle builds without KVM #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions as required
…orts different container engines (docker or podman)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows container startup when KVM is not available.
Previously, the build would fail if
/dev/kvmwas missing or if--group-addwas passed without a corresponding kvm group.This change checks for KVM availability. If it’s not present, the container starts without
--group-addand--user, allowing the build to fall back to host execution.Testing Notes
With KVM available: Verify that builds still succeed, and
--group-add&--useroptions are applied.Without KVM: Verified that builds proceed without KVM, falling back gracefully without requiring User-Mode Linux.
Check that the VM images are generated successfully in both scenarios.
Housekeeping
Renames
PODMANvar toCONTAINER_ENGINE.