Conversation
There are too many options in the advanced detector to fit in with the default GUI size. The scroll bar does not appear if not needed.
The main channel is 1-value, the secondary one is 0-valued, and they cannot be larger than the number of channels cellpose accepts.
Also target version is 1.0.0
The other 3 detectors are currently broken. And the non-GPU version does not work (one CLI instance but several folders in which the images are saved...)
The reason was that the same instance of the cli was used in all threads, each setting a different target folder to save the images. Of course this led to race conditions. The easy fix was to put the setting of the target folder and the generation of the command line in a synchronized block. Not neat but works.
It cannot work as is, without extra, inelegant gymnastics. Mainly: how can we inform the CLI how many channels etc we have? And the factory should not have any field!!
Only two classes. Nice!
I want to be able to specify another default value for omnipose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces Omnipose integration
Rework Cellpose integration -> made for Cellpose 3
Add a Cellpose-SAM integration