You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was unable to reproduce the yt wanix demo, where a new Iframe's src points to opfs via /:/web/opfs.
I found 2 issues, the service worker wasn't registered, and once it was it was caching the opfs file, so any change had no effect.
Hmmm actually I'm not sure where those changes originated?!
I just saw that runtime/wasi/worker/lib.js is generated by esbuild,
and thought maybe I got a newer esbuild version, as te changes seemed minor/cosmetic.
But deleted it and tried to regenerate ... and couldn't.
So just removed that commit from the PR, and it still fixes the 404 error reproducible by iframe.sh
I was thinking that as we already use cloudflare:
We could use its pages feature for being able to deploy every commit/branch on its on preview url. So a PR could be easily checked by letting cf-pages serve a static dir from wanix export + the bundle.tgz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to reproduce the yt wanix demo, where a new Iframe's src points to opfs via
/:/web/opfs.I found 2 issues, the service worker wasn't registered, and once it was it was caching the opfs file, so any change had no effect.