Fix conflation logic and update tests for data handling #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects the logic in DataConflater to use the updated last row for conflation, ensuring proper chunk merging. Updates the HorzScaleOptions documentation for clarity, adjusts the test data size in the E2E test, and adds a missing mock method in the unit test.
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the logic in
DataConflaterto use the updated last row for conflation, ensuring proper chunk merging. Updates theHorzScaleOptionsdocumentation for clarity, adjusts the test data size in the E2E test, and adds a missing mock method in the unit test.Address some review comments on the #1945 PR.