Skip to content

cmd/goexports,stdlib: parallelize symbols generation for stdlib #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented Aug 1, 2019

Fixes #314.

@sbinet
Copy link
Contributor Author

sbinet commented Aug 1, 2019

needs #311.

@ldez ldez added area/extract wrapper generation contributor/waiting-for-corrections enhancement New feature or request labels Aug 1, 2019
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I'm also working on the goexports command to add a smarter generation by platform, then I am interested in your change.

Could you improve the PR description.

Note: Linked PRs (or WIP PRs) are a pain to review, in this case, I would recommend waiting a bit before opening a new PR.

@ldez
Copy link
Contributor

ldez commented Aug 5, 2019

As I say, I'm working on the goexports command to add a smarter generation by platform.
Use parallelism is a good idea but I will change the core of goexports.
Then we will wait until I finished the smarter generation.

@sbinet
Copy link
Contributor Author

sbinet commented Aug 5, 2019

ok. alternatively: we could make goexports smarter and recognize (like go list does) the "meta" package stdlib and have it automatically generate wrappers for all the packages that are in stdlib.

@sbinet sbinet closed this Aug 5, 2019
@ldez
Copy link
Contributor

ldez commented Aug 5, 2019

I do not understand why you close this PR. We are really interested in this PR.

@ldez
Copy link
Contributor

ldez commented Aug 5, 2019

If it's a problem, I can review this PR before creating mine, I try to do my best.

@ldez ldez removed the bot/no-merge label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extract wrapper generation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate: speed-up symbols generation via goexports
2 participants