Skip to content

refactor: exception handling in Rescue macro #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
seuros wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: exception handling in Rescue macro #54

seuros wants to merge 1 commit into from

Conversation

@seuros
Copy link
Member

@seuros seuros commented Dec 2, 2024

Introduced a constant DEFAULT_EXCEPTIONS to replace inline definition of exceptions.

@seuros
refactor: exception handling in Rescue macro
aec40d8 
Introduced a constant DEFAULT_EXCEPTIONS to replace inline definition of exceptions.
@seuros seuros requested a review from apotonick December 2, 2024 11:51
@apotonick
Copy link
Member

apotonick commented Dec 6, 2024

Could you elaborate why this is better? THaaaaanks ☕

@seuros
Copy link
Member Author

seuros commented Dec 6, 2024

1 - the value is frozen and used across all calls.
2 - you can overwrite it in your app if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apotonick apotonick Awaiting requested review from apotonick

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seuros @apotonick