fix: resolve QR code generation silently failing after uv migration#15017
Open
rramphal wants to merge 1 commit into
Open
fix: resolve QR code generation silently failing after uv migration#15017rramphal wants to merge 1 commit into
rramphal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
which segno && segno ... || truewith a direct path via{{ ansible_playbook_python | dirname }}/segno, resolving the binaryfrom the same venv that Ansible is running in.
Motivation and Context
The QR code task uses
which segno && segno ... || true, which relies onthe venv
bin/being on PATH. This works when running via./algooruv run ansible-playbook, but silently produces no QR codes when Ansibleis invoked outside the project venv (e.g., system ansible or
uv tool run --from ansible-core).This is the only task in the playbooks that uses
whichto locate avenv-installed binary — everything else goes through Python imports via
ansible_python_interpreter, which is why nothing else breaks outsidethe venv.
Using
{{ ansible_playbook_python | dirname }}/segnoresolves the binarydirectly from the venv, removing the PATH dependency.
|| trueis alsoremoved — segno is a declared dependency in
pyproject.toml, so a failureshould be surfaced, not swallowed.
How Has This Been Tested?
segnogenerates valid PNGs when invoked via thedirnamepathapproach, including with multiline WireGuard config content
ansible-lint,yamllint)a maintainer before merging
Types of changes
Checklist:
./scripts/lint.sh)==1.2.3not>=1.2.0).