Uniformize import matching analysis#255
Open
thomas-chauchefoin-tob wants to merge 4 commits intomasterfrom
Open
Uniformize import matching analysis#255thomas-chauchefoin-tob wants to merge 4 commits intomasterfrom
thomas-chauchefoin-tob wants to merge 4 commits intomasterfrom
Conversation
sys.stdlib_module_names only contains top-level names, so
is_std_module("os.path") incorrectly returned False. This caused
NonStandardImports to flag stdlib submodule imports as non-standard.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
UnsafeImportsML now works with both ast.ImportFrom and ast.Import AST nodes tu support Ext1/2/4 opcodes. The eval check is now independent of the UNSAFE_IMPORTS branch, so it also triggers for module listed in UNSAFE_IMPORTS. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a few crashes and inconsistencies in import analysis:
is_std_module()to handle dotted imports (os.path,collections.abc), and reduce false positives inNonStandardImportsUnsafeImportsMLandUnsafeImportsto handleast.Importnodes generated by Ext opcodesUnsafeImportsML.analyze()for uniform extraction of module names from bothast.ImportFromandast.Importnodesevalimport check that was skipped when the module was inUNSAFE_IMPORTS