perf: Add __slots__ to hot classes #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add __slots__ declarations to frequently instantiated classes to reduce memory overhead and improve attribute access speed: - bounds.py: Infinity, Range, ConstantBound, BoundedComparator - edits.py: AbstractEdit and all subclasses (Match, Replace, etc.) - graphtage.py: KeyValuePairEdit, FixedKeyDictNodeEdit, StringEdit - levenshtein.py: EditDistance - multiset.py: MultiSetEdit - sequences.py: SequenceEdit, FixedLengthSequenceEdit Range objects are created 230k+ times per diff. Without __slots__, each has a 296-byte __dict__ overhead. With __slots__, total object size is 48 bytes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
__slots__to frequently instantiated classesChanges
Benchmark
Range objects are created 230k+ times per 200-element list diff. Each Range without
__slots__has a 296-byte__dict__overhead. With__slots__, total object size is 48 bytes - an 86% memory reduction per object.Test plan
🤖 Generated with Claude Code