perf: Use heap in make_distinct() for O(n log n) complexity #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace O(n²) linear search for biggest interval with heap-based approach. The previous implementation searched all intervals linearly on each iteration of the outer loop. Now we use a max-heap to find the biggest interval in O(log n) amortized time. Key changes: - Use heapq with negative sizes for max-heap behavior - Track valid intervals with a set for O(1) membership checks - Re-add intervals to heap with updated sizes after tightening - Handle stale heap entries by verifying sizes before use This improves performance for diffs with many overlapping edit bounds. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
In
bounds.py:make_distinct(), the previous implementation searched all intervals linearly on each iteration to find the biggest interval. This made the overall complexity O(n²).Now we use a max-heap (via
heapqwith negative sizes) to find the biggest interval in O(log n) amortized time:Complexity Analysis
Test plan
🤖 Generated with Claude Code