Refactor interpreter to policy-based library#583
Merged
Conversation
Extract the interpreter from a 3500-line monolith in InterpretIR.cpp into a reusable library at lib/IR/Interpret/ with policy interfaces (ValueFactory, Memory, Driver). The interpreter is now a state transition function: InitState() sets up the call stack, Step() advances one block, and the caller owns the loop. Key design changes: - InterpreterState struct + free functions replace the Interpreter class - CALL pushes callee frames onto a shared call stack; RET pops them (no more recursive child interpreter instances) - Pointer provenance tracked in Memory (WritePointer/ReadPointer) instead of per-frame pointer_shadow maps - Global addresses stored on InterpreterState, not a shared_ptr map - Suspension/Resolution variants for branch, call, global, and pointer resolution enable future symbolic/abstract drivers - Frame layout (frameOffset, frameSizeBytes) computed at codegen time Also includes codegen fixes for Duff's device, implicit switch defaults, goto-into-scope, va_copy, CONSUME_VA_PARAM wrapping, and sized opcodes. 34/34 interpreter tests pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kumarak
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InterpretIR.cppinto a reusable library atlib/IR/Interpret/with policy interfaces (ValueFactory,Memory,Driver)Interpreterclass withInterpreterStatestruct + free functions (InitState/Step) — the interpreter is now a state transition function, not an objectMemoryinstead of per-frame shadow mapsTest plan
🤖 Generated with Claude Code